]> Cypherpunks repositories - gostls13.git/commit
net/http: add field Cookie.Quoted bool
authorNuno Gonçalves <nunomrgoncalves@tecnico.ulisboa.pt>
Thu, 18 Apr 2024 19:30:26 +0000 (19:30 +0000)
committerDamien Neil <dneil@google.com>
Fri, 19 Apr 2024 00:32:19 +0000 (00:32 +0000)
commita63907808d14679c723e566cb83acc76fc8cafc2
tree8128b0aadc184273b8bc254f741caa9465c20549
parent01064622a21f921a54c4442ef9f5436c89e998c7
net/http: add field Cookie.Quoted bool

The current implementation of the http package strips double quotes
from the cookie-value during parsing, resulting in the serialized
cookie not including them. This patch addresses this limitation by
introducing a new field to track whether the original value was
enclosed in quotes.

Additionally, the internal representation of a cookie in the cookiejar
package has been adjusted to align with the new representation.

The syntax of cookies is outlined in RFC 6265 Section 4.1.1:
https://datatracker.ietf.org/doc/html/rfc6265\#section-4.1.1

Fixes #46443

Change-Id: Iac12a56397d77a6060a75757ab0daeacc60457f3
GitHub-Last-Rev: a76440e741440cddaa05944b6828a14a32b5a44a
GitHub-Pull-Request: golang/go#66752
Reviewed-on: https://go-review.googlesource.com/c/go/+/577755
Reviewed-by: Damien Neil <dneil@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
api/next/46443.txt [new file with mode: 0644]
doc/next/6-stdlib/99-minor/net/http/46443.md [new file with mode: 0644]
src/net/http/cookie.go
src/net/http/cookie_test.go
src/net/http/cookiejar/jar.go
src/net/http/cookiejar/jar_test.go
src/net/http/request.go