]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: clean up SSA test API
authorJosh Bleecher Snyder <josharian@gmail.com>
Sun, 19 Mar 2017 05:00:28 +0000 (22:00 -0700)
committerJosh Bleecher Snyder <josharian@gmail.com>
Sun, 19 Mar 2017 05:37:39 +0000 (05:37 +0000)
commita68e5d94fad421e64d471dae1c5ee0b95b933242
treed1718f76809e68d4021b5dfb9f6e0922521ffe78
parent62947bedd28a884b46f5df71070a9e86dad17081
cmd/compile: clean up SSA test API

I noted in CL 38327 that the SSA test API felt a bit
clunky after the ssa.Func/ssa.Cache/ssa.Config refactoring,
and promised to clean it up once the dust settled.
The dust has settled.

Along the way, this CL fixes a potential latent bug,
in which the amd64 test context was used for all dummy Syslook calls.
The lone SSA test using the s390x context did not depend on the
Syslook context being correct, so the bug did not arise in practice.

Change-Id: If964251d1807976073ad7f47da0b1f1f77c58413
Reviewed-on: https://go-review.googlesource.com/38346
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
17 files changed:
src/cmd/compile/internal/ssa/copyelim_test.go
src/cmd/compile/internal/ssa/cse_test.go
src/cmd/compile/internal/ssa/deadcode_test.go
src/cmd/compile/internal/ssa/deadstore_test.go
src/cmd/compile/internal/ssa/dom_test.go
src/cmd/compile/internal/ssa/export_test.go
src/cmd/compile/internal/ssa/func_test.go
src/cmd/compile/internal/ssa/fuse_test.go
src/cmd/compile/internal/ssa/lca_test.go
src/cmd/compile/internal/ssa/loop_test.go
src/cmd/compile/internal/ssa/nilcheck_test.go
src/cmd/compile/internal/ssa/passbm_test.go
src/cmd/compile/internal/ssa/regalloc_test.go
src/cmd/compile/internal/ssa/schedule_test.go
src/cmd/compile/internal/ssa/shift_test.go
src/cmd/compile/internal/ssa/shortcircuit_test.go
src/cmd/compile/internal/ssa/writebarrier_test.go