]> Cypherpunks repositories - gostls13.git/commit
encoding/json: reduce error text regressions under goexperiment.jsonv2
authorJoe Tsai <joetsai@digital-static.net>
Thu, 24 Jul 2025 18:34:18 +0000 (11:34 -0700)
committerGopher Robot <gobot@golang.org>
Fri, 25 Jul 2025 03:30:25 +0000 (20:30 -0700)
commita6eec8bdc79a89f6001d7788d280b8910c5f1b13
tree8ee43d469512cbdeaa0847eae2dc7d3ea1419a88
parent0fa88dec1e23ceeef9f5719e0f9ccb94766e53e7
encoding/json: reduce error text regressions under goexperiment.jsonv2

There were minor and unnecessary error text changes
when v1 was implemented using v2.
Reduce divergences if possible.

Of the cases reported in #74713, there are no more differences for:

v1: json: cannot unmarshal number into Go value of type chan int
v2: json: cannot unmarshal number into Go value of type chan int

and

v1: json: cannot unmarshal number into Go value of type error
v2: json: cannot unmarshal number into Go value of type error

However, there is a difference between:

v1: json: cannot unmarshal string into Go struct field .F.V of type int
v2: json: cannot unmarshal string into Go struct field S.F.V of type int

For reasons unclear, the v1 logic was always inconsistent about
whether it could properly record the root struct type,
while the v1 emulation layer under v2 is always able to.

This only modifies code that is compiled in under goexperiment.jsonv2.

Fixes #74713

Change-Id: I9e87323b1810130cb929288fdd86aff4be82d5f2
Reviewed-on: https://go-review.googlesource.com/c/go/+/689918
Reviewed-by: Damien Neil <dneil@google.com>
Auto-Submit: Joseph Tsai <joetsai@digital-static.net>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
src/encoding/json/decode_test.go
src/encoding/json/internal/internal.go
src/encoding/json/v2/arshal_default.go
src/encoding/json/v2/arshal_test.go
src/encoding/json/v2/errors.go
src/encoding/json/v2_decode.go
src/encoding/json/v2_decode_test.go
src/encoding/json/v2_inject.go