]> Cypherpunks repositories - gostls13.git/commit
runtime: allow calling Func.Name on nil pointer
authorJoe Tsai <joetsai@digital-static.net>
Fri, 30 Jun 2017 22:44:25 +0000 (15:44 -0700)
committerJoe Tsai <thebrokentoaster@gmail.com>
Fri, 30 Jun 2017 23:42:03 +0000 (23:42 +0000)
commita776087ee3b5780975b51db6a5d66cb7be7c50d4
treef06aff3ac06550b4d5edb7e66ae2f436063fff53
parent445652f45361d4935a828f394d7f0322faa6d9ad
runtime: allow calling Func.Name on nil pointer

The Func type has allowed calling the Func.Name method on a nil pointer
since Go1.2, where it returned an empty string. A regression caused by
CL/37331 caused this behavior to change. This breaks code that lazily
does runtime.FuncForPC(myPtr).Name() without first checking that myPtr
is actually non-nil.

Fixes #20872

Change-Id: Iae9a2ebabca5e9d1f5a2cdaf2f30e9c6198fec4f
Reviewed-on: https://go-review.googlesource.com/47354
Reviewed-by: Marvin Stenger <marvin.stenger94@gmail.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/runtime/symtab.go
src/runtime/symtab_test.go