]> Cypherpunks repositories - gostls13.git/commit
runtime: fix mcall unwinding on Windows
authorqmuntal <quimmuntal@gmail.com>
Wed, 24 Apr 2024 07:36:22 +0000 (09:36 +0200)
committerQuim Muntal <quimmuntal@gmail.com>
Thu, 25 Apr 2024 18:50:21 +0000 (18:50 +0000)
commita8ba163695f605c72156c90de97a06b3e40566ff
treec0f8f4f861b7fdae3dd25ab3f25e3f12d73c9cff
parentfd99157f9d9c22eb35ea9c70f32908f0980d47ed
runtime: fix mcall unwinding on Windows

The Windows native stack unwinder incorrectly classifies the next
instruction after the mcall callback call as being part of the function
epilogue, producing a wrong call stack.

Add a NOP after the callback call to work around this issue.

Fixes #67007.

Change-Id: I6017635da895b272b1852391db9a255ca69e335d
Reviewed-on: https://go-review.googlesource.com/c/go/+/581335
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Run-TryBot: Quim Muntal <quimmuntal@gmail.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
src/runtime/asm_amd64.s