]> Cypherpunks repositories - gostls13.git/commit
cmd/go: fix a portability issue in the cd script command
authorManlio Perillo <manlio.perillo@gmail.com>
Thu, 13 May 2021 14:08:59 +0000 (16:08 +0200)
committerBryan C. Mills <bcmills@google.com>
Fri, 14 May 2021 15:35:28 +0000 (15:35 +0000)
commita938e529861215d9721f5e2590d5166bfbf2d271
tree34d79cc79ecd77effc306f0a1cf833027e956cb2
parentd137b745398e8313c0f086d4d044751295be6163
cmd/go: fix a portability issue in the cd script command

Currently all script tests use the UNIX path separator with the cd
command, causing the PWD environment variable to have the incorrect path
separator on Windows.

Call filepath.FromSlash on the cd command argument.
Update the testdata/script/README to document that the cd argument must
use slashes.

Add a regression test.

To reproduce this issue, a test must use the cd command followed by a
stdout or stderr command containing the pattern $PWD.

Change-Id: Ib2dc5f185cc2476451402787996d14df91f7dddb
Reviewed-on: https://go-review.googlesource.com/c/go/+/319311
Reviewed-by: Jay Conrod <jayconrod@google.com>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Trust: Jay Conrod <jayconrod@google.com>
Run-TryBot: Jay Conrod <jayconrod@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
src/cmd/go/script_test.go
src/cmd/go/testdata/script/README
src/cmd/go/testdata/script/test_script_cmdcd.txt [new file with mode: 0644]