]> Cypherpunks repositories - gostls13.git/commit
cmd/dist: spin up fewer test dir runners
authorJosh Bleecher Snyder <josharian@gmail.com>
Tue, 2 May 2017 12:35:55 +0000 (05:35 -0700)
committerJosh Bleecher Snyder <josharian@gmail.com>
Tue, 2 May 2017 13:39:51 +0000 (13:39 +0000)
commita93e9f0fad01c0be444d89d1e46d1d357128b4bc
tree3bb03e84136d964a1abc7380ff9a7ff73cb74d37
parent18fb670e5ee038ab681562a6b018da516f6a6f9f
cmd/dist: spin up fewer test dir runners

5 shards, each of which spins up NumCPU processes,
each of which is running at GOMAXPROCS=NumCPU,
is too much for one machine. It makes my laptop unusable.

It might also be in part responsible for test flakes
that require a moderately responsive system,
like #18589 (backedge scheduling) and #19276 (locklinear).

It's possible that Go should be a better neighbor in general;
that's #17969. In the meantime, fix this corner of the world.

Builders snapshot the world and run shards on different
machines, so keeping sharding high for them is good.

This is a partial reversion of CL 18199.

Fixes #20141.

Change-Id: I123cf9436f4f4da3550372896265c38117b78071
Reviewed-on: https://go-review.googlesource.com/42431
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/cmd/dist/test.go