]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.18] misc/cgo/testcshared: handle unsuffixed dlltool path
authorThan McIntosh <thanm@google.com>
Thu, 17 Nov 2022 20:29:27 +0000 (15:29 -0500)
committerCarlos Amedee <carlos@golang.org>
Mon, 9 Jan 2023 21:17:14 +0000 (21:17 +0000)
commitaa0c01fb35bc7f95d46c77020bc56a58eaa80edd
treed1b48bd7c40d20284bd3759d1eccd06d7d9400ee
parent87105e5b2e3462cb5d62d9a8e08b9e45f65ed671
[release-branch.go1.18] misc/cgo/testcshared: handle unsuffixed dlltool path

Adapt the testcshared tests to handle the case where the path output
by invoking

  gcc -print-prog-name=dlltool

is a path lacking the final ".exe" suffix (this seems to be what clang
is doing); tack it on before using if this is the case.

Updates #57704.
Fixes #57705.

Change-Id: I04fb7b9fc90677880b1ced4a4ad2a8867a3f5f86
Reviewed-on: https://go-review.googlesource.com/c/go/+/451816
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Than McIntosh <thanm@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
(cherry picked from commit 771a98d6b19c9ca4bbd3fbeba03d7d512f77c166)
Reviewed-on: https://go-review.googlesource.com/c/go/+/461176
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
misc/cgo/testcshared/cshared_test.go