]> Cypherpunks repositories - gostls13.git/commit
crypto/tls: Fix c.in.decrypt error handling.
authorDavid Benjamin <davidben@google.com>
Fri, 1 Jul 2016 20:41:09 +0000 (16:41 -0400)
committerAdam Langley <agl@golang.org>
Fri, 30 Sep 2016 18:44:37 +0000 (18:44 +0000)
commitab6ba99484b637bad0c5a5fa2c590834c14746c7
tree5f7ab5835184829d827bbcac9376710ae7309899
parent01661612e433deadec99229c6075baa4174ac743
crypto/tls: Fix c.in.decrypt error handling.

readRecord was not returning early if c.in.decrypt failed and ran
through the rest of the function. It does set c.in.err, so the various
checks in the callers do ultimately notice before acting on the result,
but we should avoid running the rest of the function at all.

Also rename 'err' to 'alertValue' since it isn't actually an error.

Change-Id: I6660924716a85af704bd3fe81521b34766238695
Reviewed-on: https://go-review.googlesource.com/24709
Run-TryBot: Adam Langley <agl@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Adam Langley <agl@golang.org>
src/crypto/tls/conn.go