]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: fix no-op instruction used by s390x
authorKeith Randall <keithr@alum.mit.edu>
Mon, 31 Dec 2018 23:03:33 +0000 (15:03 -0800)
committerKeith Randall <khr@golang.org>
Thu, 3 Jan 2019 17:00:47 +0000 (17:00 +0000)
commitabd1dde1f717f86f94774ce9ab56053947f2d175
tree96c27be904cf17a1a8916fde4d508e4cca57561e
parent0175064e697d3e072573b32173299b7edbda7360
cmd/compile: fix no-op instruction used by s390x

CL 152537 introduced a new use for ginsnop, the arch-dependent
routine that generates nops. The previous s390x nop clobbered flags.
It turns out the previous uses of this nop did not require flags
to be preserved, but the new use does.

Use a real nop: the 4-byte preferred nop.

Fixes #29453

Change-Id: I95310dfdd831932e26f5d5b6608324687f4c3162
Reviewed-on: https://go-review.googlesource.com/c/155926
Reviewed-by: Michael Munday <mike.munday@ibm.com>
src/cmd/compile/internal/s390x/ggen.go