]> Cypherpunks repositories - gostls13.git/commit
runtime: drop stack-allocated pcvalueCaches
authorAustin Clements <austin@google.com>
Tue, 1 Aug 2023 18:41:42 +0000 (14:41 -0400)
committerGopher Robot <gobot@golang.org>
Mon, 7 Aug 2023 19:31:26 +0000 (19:31 +0000)
commitaca6577196d61073a74c2ba791aa89c166db9521
treeb1f65f81b435d59dad440fcf420f16dbd94406a4
parentd367ec6a0ed0c016603c8aba697710a131a70db8
runtime: drop stack-allocated pcvalueCaches

Now that pcvalue keeps its cache on the M, we can drop all of the
stack-allocated pcvalueCaches and stop carefully passing them around
between lots of operations. This significantly simplifies a fair
amount of code and makes several structures smaller.

This series of changes has no statistically significant effect on any
runtime Stack benchmarks.

I also experimented with making the cache larger, now that the impact
is limited to the M struct, but wasn't able to measure any
improvements.

Change-Id: I4719ebf347c7150a05e887e75a238e23647c20cd
Reviewed-on: https://go-review.googlesource.com/c/go/+/515277
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Austin Clements <austin@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Run-TryBot: Austin Clements <austin@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
14 files changed:
src/runtime/debugcall.go
src/runtime/heapdump.go
src/runtime/mbitmap.go
src/runtime/mgcmark.go
src/runtime/mgcstack.go
src/runtime/preempt.go
src/runtime/race.go
src/runtime/stack.go
src/runtime/stkframe.go
src/runtime/symtab.go
src/runtime/symtabinl.go
src/runtime/symtabinl_test.go
src/runtime/trace.go
src/runtime/traceback.go