]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.13] runtime: ensure memmove write pointer atomically on ARM64
authorCherry Zhang <cherryyz@google.com>
Fri, 27 Dec 2019 17:02:00 +0000 (12:02 -0500)
committerAlexander Rakoczy <alex@golang.org>
Wed, 8 Jan 2020 22:22:13 +0000 (22:22 +0000)
commitacc723af2646200d13f76ffde80b000c4095074a
treec6b9e2c00fa4ddceed8ef5df21ba3133bdf2d1a6
parent367da16e91af75888e44b02932d228af7c9b0244
[release-branch.go1.13] runtime: ensure memmove write pointer atomically on ARM64

If a pointer write is not atomic, if the GC is running
concurrently, it may observe a partially updated pointer, which
may point to unallocated or already dead memory. Most pointer
writes, like the store instructions generated by the compiler,
are already atomic. But we still need to be careful in places
like memmove. In memmove, we don't know which bits are pointers
(or too expensive to query), so we ensure that all aligned
pointer-sized units are written atomically.

Fixes #36361.
Updates #36101.

Change-Id: I1b3ca24c6b1ac8a8aaf9ee470115e9a89ec1b00b
Reviewed-on: https://go-review.googlesource.com/c/go/+/212626
Reviewed-by: Austin Clements <austin@google.com>
(cherry picked from commit ffbc02761abb47106ce88e09290a31513b5f6c8a)
Reviewed-on: https://go-review.googlesource.com/c/go/+/213683
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
src/runtime/memmove_arm64.s