]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.21] runtime/pprof: fix generics function names
authorTolya Korniltsev <korniltsev.anatoly@gmail.com>
Mon, 4 Dec 2023 10:53:29 +0000 (17:53 +0700)
committerGopher Robot <gobot@golang.org>
Thu, 4 Jan 2024 17:22:01 +0000 (17:22 +0000)
commitad1ec60a5bae4e8afef7a5ee68fac80a758e4395
tree4d29f2e9214ec5889d730555679205d3fc85eb98
parentbbab863ada264642e2755f123ef3f84a6b3451d0
[release-branch.go1.21] runtime/pprof: fix generics function names

profileBuilder is using Frame->Function as key for checking if we already
emitted a function. However for generics functions it has dots there [...],
so sometimes for different functions with different generics types,
the profileBuilder emits wrong functions.

For #64528
For #64609

Change-Id: I8b39245e0b18f4288ce758c912c6748f87cba39a
Reviewed-on: https://go-review.googlesource.com/c/go/+/546815
Reviewed-by: Cherry Mui <cherryyz@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
(cherry picked from commit 20a03fc7130d8d99b513071c7e413b436ea649a2)
Reviewed-on: https://go-review.googlesource.com/c/go/+/549535
Auto-Submit: Matthew Dempsky <mdempsky@google.com>
src/runtime/pprof/proto.go
src/runtime/pprof/protomem_test.go