]> Cypherpunks repositories - gostls13.git/commit
cmd/go: rename flag counters and add buildmode values separately
authorMichael Matloob <matloob@golang.org>
Wed, 1 May 2024 18:17:24 +0000 (14:17 -0400)
committerMichael Matloob <matloob@golang.org>
Wed, 8 May 2024 16:49:53 +0000 (16:49 +0000)
commitad27916c24860576a2aec4cff6a295c340aafe3c
tree83990eb5cda5825c1b49615590375c5082bb0ec4
parent328aa9e39f3a5da785daa015d673f19ded9e13ae
cmd/go: rename flag counters and add buildmode values separately

Rename the subcommand flag counter names from
go/flag/<subcommand>/<flagname> to go/<subcommand>/flag/<flagname>.

Also remove the special case that adds counters for buildmode flag
values and instead add an additional counter for the flag values.
The new counter has the form go/<subcommand>/flag/buildmode:<flagvalue>.
We use a new CountFlagValue function that's been added to the
internal/telemetry package to help with this.

Finally add the go/invocations counter

Change-Id: I995b6b0009ba0f58faeb3e2a75f3b137e4136209
Reviewed-on: https://go-review.googlesource.com/c/go/+/583917
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Robert Findley <rfindley@google.com>
src/cmd/go/main.go
src/cmd/internal/telemetry/telemetry.go
src/cmd/internal/telemetry/telemetry_bootstrap.go