]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: run deadcode before nilcheck for better statement relocation
authorDavid Chase <drchase@google.com>
Mon, 30 Sep 2019 15:12:29 +0000 (11:12 -0400)
committerDavid Chase <drchase@google.com>
Thu, 3 Oct 2019 21:12:13 +0000 (21:12 +0000)
commitadc4d2cc2dbc20c14bae7bbdbca8d75421e1bef5
treef859739b569fd3682291b60186cd41d55e85f229
parent08a87938bb95ae8859600be20a998fbb4b904915
cmd/compile: run deadcode before nilcheck for better statement relocation

Nilcheck would move statements from NilCheck values to others that
turned out were already dead, which leads to lost statements.  Better
to eliminate the dead code first.

One "error" is removed from test/prove.go because the code is
actually dead, and the additional deadcode pass removes it before
prove can run.

Change-Id: If75926ca1acbb59c7ab9c8ef14d60a02a0a94f8b
Reviewed-on: https://go-review.googlesource.com/c/go/+/198479
Run-TryBot: David Chase <drchase@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jeremy Faller <jeremy@golang.org>
src/cmd/compile/internal/ssa/compile.go
test/prove.go