]> Cypherpunks repositories - gostls13.git/commit
encoding/json: remove unnecessary isValidNumber call
authorDaniel Martí <mvdan@mvdan.cc>
Tue, 2 Jul 2019 22:37:05 +0000 (00:37 +0200)
committerDaniel Martí <mvdan@mvdan.cc>
Tue, 27 Aug 2019 17:53:55 +0000 (17:53 +0000)
commitae68a912725e5a3a0482bc5945687663f2ddafe3
tree9d3bf711bf5e5ae76c2e7505e73b4abcdb1aaeb9
parentb9bf2f5d2bb117f806aef84d99ad60adbcb0cc21
encoding/json: remove unnecessary isValidNumber call

The decoder called this function to check numbers being decoded into a
json.Number. However, these can't be quoted as strings, so the tokenizer
has already verified they are valid JSON numbers.

Verified this by adding a test with such an input. As expected, it
produces a syntax error, not the fmt.Errorf - that line could never
execute.

Since the only remaining non-test caller of isvalidnumber is in
encode.go, move the function there.

This change should slightly reduce the amount of work when decoding into
json.Number, though that isn't very common nor part of any current
benchmarks.

Change-Id: I67a1723deb3d18d5b542d6dd35f3ae56a43f23eb
Reviewed-on: https://go-review.googlesource.com/c/go/+/184817
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
src/encoding/json/decode.go
src/encoding/json/decode_test.go
src/encoding/json/encode.go