]> Cypherpunks repositories - gostls13.git/commit
cmd/trace: fix the broken link in region pages and improve UX
authorRohith Ravi <entombedvirus@gmail.com>
Sun, 19 Apr 2020 02:21:15 +0000 (02:21 +0000)
committerHyang-Ah Hana Kim <hyangah@gmail.com>
Tue, 21 Apr 2020 14:57:43 +0000 (14:57 +0000)
commitaf55060b39d2f6f39711abc95a23bd8f47968e8e
tree4a4553517ef29e3ce7146eb155b4e2eb76ba07eb
parent664d2707276b3523895d98f1233c3ad7b7297220
cmd/trace: fix the broken link in region pages and improve UX

The trace tool had a broken link due to a parameter encoding error,
which has been corrected.

In addition:

- the user regions page has been enhanced to include links to
pprof style profiles for region specific io, block, syscall and
schedwait profiles.

- sortable table headers have a pointer cursor to indicate they're
clickable.

Fixes #38518

Change-Id: I26cd5157bd9753750f5f53ea03aac5d2d41b021c
Reviewed-on: https://go-review.googlesource.com/c/go/+/228899
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
src/cmd/trace/annotations.go
src/cmd/trace/goroutines.go