]> Cypherpunks repositories - gostls13.git/commit
cmd/link: check for reflect.Value.MethodByName explicitly
authorCherry Zhang <cherryyz@google.com>
Sun, 19 Apr 2020 03:08:36 +0000 (23:08 -0400)
committerCherry Zhang <cherryyz@google.com>
Sun, 19 Apr 2020 03:23:59 +0000 (03:23 +0000)
commitaf9ab6b2e852c4177db06cf91edc7a869b4cb93e
treef0cce77d09f2d7e10b1cccf06b61138ba1359d9e
parenta32262d4625e6f54cedd765e4807c215d1deb992
cmd/link: check for reflect.Value.MethodByName explicitly

Currently we only check for reflect.Value.Method. And
reflect.Value.MethodByName is covered since it calls
reflect.Value.Method internally. But it is brittle to rely on
implementation detail of the reflect package. Check for
MethodByName explicitly.

Change-Id: Ifa8920e997524003dade03abc4fb3c4e64723643
Reviewed-on: https://go-review.googlesource.com/c/go/+/228881
Run-TryBot: Cherry Zhang <cherryyz@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
src/cmd/link/internal/ld/deadcode.go
src/cmd/link/internal/ld/deadcode2.go