]> Cypherpunks repositories - gostls13.git/commit
encoding/base64, encoding/base32: make DecodeString faster
authorRui Ueyama <ruiu@google.com>
Wed, 11 Jun 2014 18:22:08 +0000 (11:22 -0700)
committerBrad Fitzpatrick <bradfitz@golang.org>
Wed, 11 Jun 2014 18:22:08 +0000 (11:22 -0700)
commitafb7b67ae99c5edfb5210ad015be934b96ecc445
tree1f5a0847757d3089e843a455018c542ffb3f629b
parentf20e4d5ecb87cae4846be07a68cb0e9132e6a8c6
encoding/base64, encoding/base32: make DecodeString faster

Previously, an input string was stripped of newline
characters at the beginning of DecodeString and then passed
to Decode. Decode again tried to strip newline characters.
That's waste of time.

benchmark                 old MB/s     new MB/s  speedup
BenchmarkDecodeString        38.37        65.20    1.70x

LGTM=dave, bradfitz
R=golang-codereviews, dave, bradfitz
CC=golang-codereviews
https://golang.org/cl/91770051
src/pkg/encoding/base32/base32.go
src/pkg/encoding/base64/base64.go
src/pkg/encoding/base64/base64_test.go