]> Cypherpunks repositories - gostls13.git/commit
internal/types: consistently use double quotes around ERROR patterns
authorRobert Griesemer <gri@golang.org>
Tue, 6 Dec 2022 22:43:39 +0000 (14:43 -0800)
committerGopher Robot <gobot@golang.org>
Tue, 17 Jan 2023 19:54:25 +0000 (19:54 +0000)
commitb003ee499a97f28a1328a8eaeb380596fad5788b
tree83c22e57a339db16f9ee03234744f16ed21c4fe6
parent3af3810a3eeef49890b3cffb8d3f2a491f1b1b35
internal/types: consistently use double quotes around ERROR patterns

Before matching the pattern, the double quotes are simply stripped
(no Go string unquoting) for now. This is a first step towards use
of proper Go strings as ERROR patterns.

The changes were obtained through a couple of global regexp
find/replace commands:

/\* ERROR ([^"]+) \*/   =>   /* ERROR "$1" */
// ERROR ([^"]+)$       =>   // ERROR "$1"

followed up by manual fixes where multiple "/* ERROR"-style
errors appeared on the same line (in that case, the first
regexp matches the first and last ERROR).

For #51006.

Change-Id: Ib92c2d5e339075aeec1ea74c339b5fecf953d1a0
Reviewed-on: https://go-review.googlesource.com/c/go/+/455718
Auto-Submit: Robert Griesemer <gri@google.com>
Reviewed-by: Robert Griesemer <gri@google.com>
Run-TryBot: Robert Griesemer <gri@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
183 files changed:
src/cmd/compile/internal/types2/check_test.go
src/cmd/compile/internal/types2/testdata/local/issue47996.go
src/go/types/check_test.go
src/go/types/issues_test.go
src/internal/types/testdata/check/blank.go
src/internal/types/testdata/check/builtins0.go
src/internal/types/testdata/check/builtins1.go
src/internal/types/testdata/check/const0.go
src/internal/types/testdata/check/constdecl.go
src/internal/types/testdata/check/cycles0.go
src/internal/types/testdata/check/cycles2.go
src/internal/types/testdata/check/cycles3.go
src/internal/types/testdata/check/cycles4.go
src/internal/types/testdata/check/cycles5.go
src/internal/types/testdata/check/decls0.go
src/internal/types/testdata/check/decls1.go
src/internal/types/testdata/check/decls4.go
src/internal/types/testdata/check/errors.go
src/internal/types/testdata/check/expr0.go
src/internal/types/testdata/check/expr1.go
src/internal/types/testdata/check/expr2.go
src/internal/types/testdata/check/expr3.go
src/internal/types/testdata/check/go1_16.go
src/internal/types/testdata/check/go1_19.go
src/internal/types/testdata/check/go1_8.go
src/internal/types/testdata/check/importC.go
src/internal/types/testdata/check/importdecl0/importdecl0b.go
src/internal/types/testdata/check/importdecl1/importdecl1b.go
src/internal/types/testdata/check/init0.go
src/internal/types/testdata/check/init1.go
src/internal/types/testdata/check/init2.go
src/internal/types/testdata/check/issues0.go
src/internal/types/testdata/check/issues1.go
src/internal/types/testdata/check/main0.go
src/internal/types/testdata/check/map0.go
src/internal/types/testdata/check/methodsets.go
src/internal/types/testdata/check/shifts.go
src/internal/types/testdata/check/slices.go
src/internal/types/testdata/check/stmt0.go
src/internal/types/testdata/check/typeinference.go
src/internal/types/testdata/check/typeinst0.go
src/internal/types/testdata/check/typeinst1.go
src/internal/types/testdata/check/typeparams.go
src/internal/types/testdata/check/unions.go
src/internal/types/testdata/check/vardecl.go
src/internal/types/testdata/examples/constraints.go
src/internal/types/testdata/examples/functions.go
src/internal/types/testdata/examples/inference.go
src/internal/types/testdata/examples/methods.go
src/internal/types/testdata/examples/operations.go
src/internal/types/testdata/examples/types.go
src/internal/types/testdata/examples/typesets.go
src/internal/types/testdata/fixedbugs/54942.go
src/internal/types/testdata/fixedbugs/issue20583.go
src/internal/types/testdata/fixedbugs/issue28251.go
src/internal/types/testdata/fixedbugs/issue39634.go
src/internal/types/testdata/fixedbugs/issue39664.go
src/internal/types/testdata/fixedbugs/issue39693.go
src/internal/types/testdata/fixedbugs/issue39699.go
src/internal/types/testdata/fixedbugs/issue39723.go
src/internal/types/testdata/fixedbugs/issue39725.go
src/internal/types/testdata/fixedbugs/issue39754.go
src/internal/types/testdata/fixedbugs/issue39768.go
src/internal/types/testdata/fixedbugs/issue39938.go
src/internal/types/testdata/fixedbugs/issue39948.go
src/internal/types/testdata/fixedbugs/issue39976.go
src/internal/types/testdata/fixedbugs/issue40056.go
src/internal/types/testdata/fixedbugs/issue40057.go
src/internal/types/testdata/fixedbugs/issue40350.go
src/internal/types/testdata/fixedbugs/issue40684.go
src/internal/types/testdata/fixedbugs/issue41124.go
src/internal/types/testdata/fixedbugs/issue42695.go
src/internal/types/testdata/fixedbugs/issue42758.go
src/internal/types/testdata/fixedbugs/issue42881.go
src/internal/types/testdata/fixedbugs/issue42987.go
src/internal/types/testdata/fixedbugs/issue43087.go
src/internal/types/testdata/fixedbugs/issue43109.go
src/internal/types/testdata/fixedbugs/issue43110.go
src/internal/types/testdata/fixedbugs/issue43124.go
src/internal/types/testdata/fixedbugs/issue43125.go
src/internal/types/testdata/fixedbugs/issue43190.go
src/internal/types/testdata/fixedbugs/issue43527.go
src/internal/types/testdata/fixedbugs/issue43671.go
src/internal/types/testdata/fixedbugs/issue45114.go
src/internal/types/testdata/fixedbugs/issue45550.go
src/internal/types/testdata/fixedbugs/issue45635.go
src/internal/types/testdata/fixedbugs/issue45639.go
src/internal/types/testdata/fixedbugs/issue45920.go
src/internal/types/testdata/fixedbugs/issue46090.go
src/internal/types/testdata/fixedbugs/issue46403.go
src/internal/types/testdata/fixedbugs/issue46461.go
src/internal/types/testdata/fixedbugs/issue46583.go
src/internal/types/testdata/fixedbugs/issue47031.go
src/internal/types/testdata/fixedbugs/issue47115.go
src/internal/types/testdata/fixedbugs/issue47127.go
src/internal/types/testdata/fixedbugs/issue47411.go
src/internal/types/testdata/fixedbugs/issue47747.go
src/internal/types/testdata/fixedbugs/issue47796.go
src/internal/types/testdata/fixedbugs/issue47818.go
src/internal/types/testdata/fixedbugs/issue47968.go
src/internal/types/testdata/fixedbugs/issue48008.go
src/internal/types/testdata/fixedbugs/issue48018.go
src/internal/types/testdata/fixedbugs/issue48048.go
src/internal/types/testdata/fixedbugs/issue48082.go
src/internal/types/testdata/fixedbugs/issue48083.go
src/internal/types/testdata/fixedbugs/issue48136.go
src/internal/types/testdata/fixedbugs/issue48312.go
src/internal/types/testdata/fixedbugs/issue48472.go
src/internal/types/testdata/fixedbugs/issue48529.go
src/internal/types/testdata/fixedbugs/issue48582.go
src/internal/types/testdata/fixedbugs/issue48619.go
src/internal/types/testdata/fixedbugs/issue48656.go
src/internal/types/testdata/fixedbugs/issue48703.go
src/internal/types/testdata/fixedbugs/issue48712.go
src/internal/types/testdata/fixedbugs/issue48819.go
src/internal/types/testdata/fixedbugs/issue48951.go
src/internal/types/testdata/fixedbugs/issue48962.go
src/internal/types/testdata/fixedbugs/issue48974.go
src/internal/types/testdata/fixedbugs/issue49003.go
src/internal/types/testdata/fixedbugs/issue49005.go
src/internal/types/testdata/fixedbugs/issue49043.go
src/internal/types/testdata/fixedbugs/issue49112.go
src/internal/types/testdata/fixedbugs/issue49179.go
src/internal/types/testdata/fixedbugs/issue49242.go
src/internal/types/testdata/fixedbugs/issue49247.go
src/internal/types/testdata/fixedbugs/issue49276.go
src/internal/types/testdata/fixedbugs/issue49296.go
src/internal/types/testdata/fixedbugs/issue49439.go
src/internal/types/testdata/fixedbugs/issue49482.go
src/internal/types/testdata/fixedbugs/issue49541.go
src/internal/types/testdata/fixedbugs/issue49579.go
src/internal/types/testdata/fixedbugs/issue49602.go
src/internal/types/testdata/fixedbugs/issue49735.go
src/internal/types/testdata/fixedbugs/issue49739.go
src/internal/types/testdata/fixedbugs/issue49864.go
src/internal/types/testdata/fixedbugs/issue50321.go
src/internal/types/testdata/fixedbugs/issue50372.go
src/internal/types/testdata/fixedbugs/issue50417.go
src/internal/types/testdata/fixedbugs/issue50516.go
src/internal/types/testdata/fixedbugs/issue50646.go
src/internal/types/testdata/fixedbugs/issue50779.go
src/internal/types/testdata/fixedbugs/issue50782.go
src/internal/types/testdata/fixedbugs/issue50816.go
src/internal/types/testdata/fixedbugs/issue50912.go
src/internal/types/testdata/fixedbugs/issue50918.go
src/internal/types/testdata/fixedbugs/issue50929.go
src/internal/types/testdata/fixedbugs/issue50965.go
src/internal/types/testdata/fixedbugs/issue51025.go
src/internal/types/testdata/fixedbugs/issue51145.go
src/internal/types/testdata/fixedbugs/issue51229.go
src/internal/types/testdata/fixedbugs/issue51232.go
src/internal/types/testdata/fixedbugs/issue51233.go
src/internal/types/testdata/fixedbugs/issue51257.go
src/internal/types/testdata/fixedbugs/issue51335.go
src/internal/types/testdata/fixedbugs/issue51339.go
src/internal/types/testdata/fixedbugs/issue51360.go
src/internal/types/testdata/fixedbugs/issue51376.go
src/internal/types/testdata/fixedbugs/issue51472.go
src/internal/types/testdata/fixedbugs/issue51509.go
src/internal/types/testdata/fixedbugs/issue51525.go
src/internal/types/testdata/fixedbugs/issue51533.go
src/internal/types/testdata/fixedbugs/issue51578.go
src/internal/types/testdata/fixedbugs/issue51593.go
src/internal/types/testdata/fixedbugs/issue51607.go
src/internal/types/testdata/fixedbugs/issue51610.go
src/internal/types/testdata/fixedbugs/issue51658.go
src/internal/types/testdata/fixedbugs/issue51877.go
src/internal/types/testdata/fixedbugs/issue52401.go
src/internal/types/testdata/fixedbugs/issue52698.go
src/internal/types/testdata/fixedbugs/issue52915.go
src/internal/types/testdata/fixedbugs/issue53358.go
src/internal/types/testdata/fixedbugs/issue54280.go
src/internal/types/testdata/fixedbugs/issue54405.go
src/internal/types/testdata/fixedbugs/issue56351.go
src/internal/types/testdata/fixedbugs/issue56665.go
src/internal/types/testdata/fixedbugs/issue57500.go
src/internal/types/testdata/fixedbugs/issue6977.go
src/internal/types/testdata/spec/assignability.go
src/internal/types/testdata/spec/comparable.go
src/internal/types/testdata/spec/comparable1.19.go
src/internal/types/testdata/spec/comparisons.go
src/internal/types/testdata/spec/conversions.go
src/internal/types/testdata/spec/oldcomparable.go