]> Cypherpunks repositories - gostls13.git/commit
runtime: record mutex event before readying
authorAustin Clements <austin@google.com>
Wed, 14 Jun 2017 15:07:24 +0000 (11:07 -0400)
committerAustin Clements <austin@google.com>
Wed, 14 Jun 2017 16:07:58 +0000 (16:07 +0000)
commitb067ad939d9ba242c5c3bdd8a24220632311c6be
tree55d3e8bd2f2c8f2e40709170b40b5d0e5722fcbb
parent738739f56543a768be1eeb9a9e33f3252f4c6da1
runtime: record mutex event before readying

Currently, semrelease1 readies the next waiter before recording a
mutex event. However, if the next waiter is expecting to look at the
mutex profile, as is the case in TestMutexProfile, this may delay
recording the event too much.

Swap the order of these operations so semrelease1 records the mutex
event before readying the next waiter. This also means readying the
next waiter is the very last thing semrelease1 does, which seems
appropriate.

Fixes #19139.

Change-Id: I1a62063599fdb5d49bd86061a180c0a2d659474b
Reviewed-on: https://go-review.googlesource.com/45751
Run-TryBot: Austin Clements <austin@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Peter Weinberger <pjw@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
src/runtime/pprof/pprof_test.go
src/runtime/sema.go