]> Cypherpunks repositories - gostls13.git/commit
cmd/asm: fix the KMCTR instruction encoding and argument passing
authorSrinivas Pokala <Pokala.Srinivas@ibm.com>
Mon, 16 Oct 2023 09:18:50 +0000 (11:18 +0200)
committerKeith Randall <khr@golang.org>
Wed, 22 Nov 2023 03:55:32 +0000 (03:55 +0000)
commitb06f59e75c5774171759fb70729b14c7f40c285c
tree33e084ece57cf2a07ae59f34b674676caaa8482a
parent5f7a40856372142372d3b67c9dd737373932f088
cmd/asm: fix the KMCTR instruction encoding and argument passing

KMCTR encoding arguments incorrect way, which leading illegal instruction wherver we call KMCTR instruction.IBM z13 machine test's TestAESGCM test using gcmASM implementation, which uses KMCTR instruction to encrypt using AES in counter mode and the KIMD instruction for GHASH. z14+ machines onwards uses gcmKMA implementation for the same.

Fixes #63387

Change-Id: I86aeb99573c3f636a71908c99e06a9530655aa5d
Reviewed-on: https://go-review.googlesource.com/c/go/+/535675
Reviewed-by: Vishwanatha HD <vishwanatha.hd@ibm.com>
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Keith Randall <khr@golang.org>
src/cmd/asm/internal/asm/testdata/s390x.s
src/cmd/internal/obj/s390x/asmz.go
src/crypto/aes/asm_s390x.s
src/internal/cpu/cpu_s390x.s