]> Cypherpunks repositories - gostls13.git/commit
database/sql: prevent race on Rows close with Tx Rollback
authorDaniel Theophanes <kardianos@gmail.com>
Sun, 11 Jun 2017 05:02:53 +0000 (22:02 -0700)
committerDaniel Theophanes <kardianos@gmail.com>
Mon, 12 Jun 2017 15:53:00 +0000 (15:53 +0000)
commitb0d592c3c9a356b661c2d6bb958528f2761d821e
tree61aa35318e1eb50f82fcb49fcbd09a78046d631a
parent3820191839a5b87acab5106b5fb43113d4f18b08
database/sql: prevent race on Rows close with Tx Rollback

In addition to adding a guard to the Rows close, add a var
in the fakeConn that gets read and written to on each
operation, simulating writing or reading from the server.

TestConcurrency/TxStmt* tests have been commented out
as they now fail after checking for races on the fakeConn.
See issue #20646 for more information.

Fixes #20622

Change-Id: I80b36ea33d776e5b4968be1683ff8c61728ee1ea
Reviewed-on: https://go-review.googlesource.com/45275
Run-TryBot: Daniel Theophanes <kardianos@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/database/sql/fakedb_test.go
src/database/sql/sql.go
src/database/sql/sql_test.go