]> Cypherpunks repositories - gostls13.git/commit
projects / gostls13.git / commit
summary | shortlog | log | commit | commitdiff | tree
(parent: 96dc044) | patch
cmd/compile: fix buggy AMD64 rewrite from CL 213058
authorRuss Cox <rsc@golang.org>
Wed, 11 Mar 2020 04:02:04 +0000 (00:02 -0400)
committerRuss Cox <rsc@golang.org>
Wed, 11 Mar 2020 16:17:24 +0000 (16:17 +0000)
commitb136f0c17bdd463207d43e73aef810fa1f14bdee
tree8cb074f60096fb2d81254c7c52ecdb5b8f8b160atree
parent96dc04412d18cc999af21cecb22dea9e7b896360commit | diff
cmd/compile: fix buggy AMD64 rewrite from CL 213058

CL 213058's "bonus optimization I noticed while working on this"
turns out to be buggy. It would be correct for CMP, but not TEST.
Fix it to use TEST semantics instead.

This was breaking compilation with the upcoming Spectre mode.

Change-Id: If2d4c3798ed182f35f0244febe74e68c61e4c61b
Reviewed-on: https://go-review.googlesource.com/c/go/+/222853
Reviewed-by: Keith Randall <khr@golang.org>
src/cmd/compile/internal/ssa/gen/AMD64.rules diff | blob | history
src/cmd/compile/internal/ssa/rewriteAMD64.go diff | blob | history
Go GOST TLS 1.3