]> Cypherpunks repositories - gostls13.git/commit
cmd/go/internal/vcs: prevent Git signatures from breaking commit time parsing
authorAndre Marianiello <andremarianiello@users.noreply.github.com>
Tue, 14 Dec 2021 22:50:28 +0000 (22:50 +0000)
committerBryan Mills <bcmills@google.com>
Thu, 16 Dec 2021 22:39:00 +0000 (22:39 +0000)
commitb1a53ece68d46e4fb59c74d2bc529060861f5dbf
tree494450b1249b88462d392aa998da612efc3fbdec
parentd01cd8fa1dc6110cbb301fd711fe43ea744cb5c9
cmd/go/internal/vcs: prevent Git signatures from breaking commit time parsing

When a user has showSignature=true set in their Git config and the
commit in question has a signature, the git-show command will output
information about that signature. When this happens, the logic that
tries to parsing a timestamp from the git-show output chokes on this
signature information and the build stamping fails. This change prevents
commit signature information from being displayed even if
showSignature=true, preventing this issue.

Change-Id: I98d0a6fdd1e90dd1b91e0394713b6eb286a69d1a
GitHub-Last-Rev: 610706e23e33a037b9abede2ba0a926c0f336814
GitHub-Pull-Request: golang/go#49790
Reviewed-on: https://go-review.googlesource.com/c/go/+/367034
Trust: Cherry Mui <cherryyz@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
src/cmd/go/internal/vcs/vcs.go
src/cmd/go/testdata/script/version_buildvcs_git_gpg.txt [new file with mode: 0644]