]> Cypherpunks repositories - gostls13.git/commit
[dev.link] cmd/compile, cmd/asm: add length to hashed symbols
authorJeremy Faller <jeremy@golang.org>
Wed, 12 Aug 2020 16:54:03 +0000 (12:54 -0400)
committerJeremy Faller <jeremy@golang.org>
Wed, 12 Aug 2020 17:14:56 +0000 (17:14 +0000)
commitb249703e3c53cd7f1e5f808fb2f03714fec44b43
treebe217a7710761cb9e0a56f0809429f91f2d3ffb8
parent9ae8f71c9431d287893443fa2b7fbdb72a9b56a2
[dev.link] cmd/compile, cmd/asm: add length to hashed symbols

While working on deduplicating pcdata, I found that the following hashed
symbols would result in the same:

[] == [0,0,0,0....]

This makes using content addressable symbols untenable for pcdata.
Adding the length to the hash keeps the dream alive.

No difference in binary size (darwin, cmd/compile), spurious
improvements in DWARF phase memory.

Change-Id: I21101f7754a3d870922b0dea39c947cc8509432f
Reviewed-on: https://go-review.googlesource.com/c/go/+/247903
Run-TryBot: Jeremy Faller <jeremy@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
Reviewed-by: Austin Clements <austin@google.com>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
src/cmd/internal/obj/objfile.go