]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: for location lists, handle case where prev block is not a pred
authorDavid Chase <drchase@google.com>
Thu, 1 Nov 2018 19:26:02 +0000 (15:26 -0400)
committerDavid Chase <drchase@google.com>
Sun, 2 Dec 2018 22:46:27 +0000 (22:46 +0000)
commitb3294d9491b898396e134bad5412d85337c37b64
tree2c7cf94647082113cafd9e2d0d4fc043d415d079
parent9e277f7d554455e16ba3762541c53e9bfc1d8188
cmd/compile: for location lists, handle case where prev block is not a pred

Before this change, location list construction would extend
from the previous (in linear order) block, even if was not a
flow predecessor.  This can cause a debugger to tell lies.

Fix accounts for this in block merging code by (crudely)
"changing" all variables live from a previous block if it
is not also a predecessor.

Fixes #28486.

Change-Id: I11336b0b969f0cd09f40f4e5f2bdfdeb02f377a4
Reviewed-on: https://go-review.googlesource.com/c/146718
Run-TryBot: David Chase <drchase@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
src/cmd/compile/internal/ssa/debug.go