]> Cypherpunks repositories - gostls13.git/commit
cmd/dist: fix build failure of misc/cgo/test on arm64
authorxd <xiangdong.ji@gmail.com>
Wed, 14 Oct 2020 18:02:49 +0000 (11:02 -0700)
committerCherry Zhang <cherryyz@google.com>
Tue, 27 Oct 2020 15:42:41 +0000 (15:42 +0000)
commitb3f7f60129b822978115717912f4d477a46e8467
treee1f905eec4a36990c780ec6a75bc78eb0a217105
parent3c55aea67aa65c62016020d5907b481da010f7e0
cmd/dist: fix build failure of misc/cgo/test on arm64

misc/cgo/test fails in 'dist test' on arm64 if the C compiler is of GCC-9.4 or
above and its 'outline atomics' feature is enabled, since the internal linking
hasn't yet supported "__attribute__((constructor))" and also mis-handles hidden
visibility.

This change addresses the problem by skipping the internal linking cases of
misc/cgo/test on linux/arm64. It fixes 'dist test' failure only, user is expected to
pass a GCC option '-mno-outline-atomics' via CGO_CFLAGS if running into the same
problem when building cgo programs using internal linking.

Updates #39466

Change-Id: I57f9e85fca881e5fd2dae6c1b4446bce9e0c1975
Reviewed-on: https://go-review.googlesource.com/c/go/+/262357
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Emmanuel Odeke <emmanuel@orijtech.com>
src/cmd/dist/test.go