]> Cypherpunks repositories - gostls13.git/commit
test/fixedbugs: fix bug248 and bug345
authorisharipo <iskander.sharipov@intel.com>
Mon, 2 Apr 2018 19:50:20 +0000 (22:50 +0300)
committerEmmanuel Odeke <emm.odeke@gmail.com>
Mon, 2 Apr 2018 20:08:27 +0000 (20:08 +0000)
commitb44e73eacbce790a1dfcad293604a4b9f5f6976f
treebb61574e8a4b47716202936d5306dae8ca0fd508
parent45ce10fa3a95cd949458c012d44f4e50b72acabd
test/fixedbugs: fix bug248 and bug345

When test/run script was removed, these two tests
were changed to be executed by test/run.go.
Because errchk does not exit with non-zero status on
errors, they were silently failing for a while.

This change makes 2 things:

1. Compile tested packages in GOROOT/test to match older runner script
   behavior (strictly required only in bug345, optional in bug248)

2. Check command output with "(?m)^BUG" regexp.
   It approximates older `grep -q '^BUG' that was used before.

See referenced issue for detailed explanation.

Fixes #24629

Change-Id: Ie888dcdb4e25cdbb19d434bbc5cb03eb633e9ee8
Reviewed-on: https://go-review.googlesource.com/104095
Run-TryBot: Iskander Sharipov <iskander.sharipov@intel.com>
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
test/fixedbugs/bug248.go
test/fixedbugs/bug345.go