]> Cypherpunks repositories - gostls13.git/commit
[dev.power64] cmd/5a, cmd/6a, cmd/8a, cmd/9a: make labels function-scoped
authorRuss Cox <rsc@golang.org>
Wed, 29 Oct 2014 01:50:16 +0000 (21:50 -0400)
committerRuss Cox <rsc@golang.org>
Wed, 29 Oct 2014 01:50:16 +0000 (21:50 -0400)
commitb55791e2008703b33883e48e72a347ba07a65486
tree2dc3ed44dc71a1aa6af2d9fbe331464408104d79
parent87b4149b22feb9d8d52da1730b455e39436a3a8d
[dev.power64] cmd/5a, cmd/6a, cmd/8a, cmd/9a: make labels function-scoped

I removed support for jumping between functions years ago,
as part of doing the instruction layout for each function separately.

Given that, it makes sense to treat labels as function-scoped.
This lets each function have its own 'loop' label, for example.

Makes the assembly much cleaner and removes the last
reason anyone would reach for the 123(PC) form instead.

Note that this is on the dev.power64 branch, but it changes all
the assemblers. The change will ship in Go 1.5 (perhaps after
being ported into the new assembler).

Came up as part of CL 167730043.

LGTM=r
R=r
CC=austin, dave, golang-codereviews, minux
https://golang.org/cl/159670043
37 files changed:
src/cmd/5a/a.h
src/cmd/5a/a.y
src/cmd/5a/y.tab.c
src/cmd/5a/y.tab.h
src/cmd/6a/a.h
src/cmd/6a/a.y
src/cmd/6a/y.tab.c
src/cmd/8a/a.h
src/cmd/8a/a.y
src/cmd/8a/y.tab.c
src/cmd/9a/a.h
src/cmd/9a/a.y
src/cmd/9a/y.tab.c
src/cmd/9a/y.tab.h
src/cmd/cc/lexbody
src/runtime/asm_386.s
src/runtime/asm_amd64.s
src/runtime/asm_amd64p32.s
src/runtime/asm_arm.s
src/runtime/asm_power64x.s
src/runtime/memclr_386.s
src/runtime/memclr_amd64.s
src/runtime/memclr_plan9_386.s
src/runtime/race_amd64.s
src/runtime/sys_darwin_386.s
src/runtime/sys_darwin_amd64.s
src/runtime/sys_dragonfly_386.s
src/runtime/sys_freebsd_386.s
src/runtime/sys_linux_amd64.s
src/runtime/sys_linux_arm.s
src/runtime/sys_nacl_386.s
src/runtime/sys_nacl_amd64p32.s
src/runtime/sys_nacl_arm.s
src/runtime/sys_openbsd_386.s
src/runtime/sys_solaris_amd64.s
src/runtime/sys_windows_386.s
src/runtime/sys_windows_amd64.s