]> Cypherpunks repositories - gostls13.git/commit
internal/xcoff: fix wrong bit masking comparisons
authorNeven Sajko <nsajko@gmail.com>
Sat, 7 Mar 2020 17:23:20 +0000 (17:23 +0000)
committerIan Lance Taylor <iant@golang.org>
Mon, 9 Mar 2020 18:07:53 +0000 (18:07 +0000)
commitb559a173f9f187e1185f8de00a9cc1f5b05aceef
tree316371bdf32d38b9be5ee3a10bbb7d4e0b9c96e6
parent43c6ada84c6ef47e3b61646d2f2e7f6b7264929d
internal/xcoff: fix wrong bit masking comparisons

I do not know much about xcoff, but this was probably the intended
behavior. (The comparison is tautologically false, as is.)

Also note: does any other code even depend on the changed code existing?
Maybe it should just be removed, as I did not find any uses of fields
that are written to if the branch condition tests true.

Change-Id: I1f23d33764df40e87f3e64460d63f6efc51a2a78
GitHub-Last-Rev: 268909130fd7fb3993fcf7004143ec48dbfe5e2a
GitHub-Pull-Request: golang/go#37733
Reviewed-on: https://go-review.googlesource.com/c/go/+/222478
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Clément Chigot <clement.chigot%atos.net@gtempaccount.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
src/internal/xcoff/file.go