]> Cypherpunks repositories - gostls13.git/commit
cmd/link/internal/riscv64: generate local text symbols for R_RISCV_CALL
authorJoel Sing <joel@sing.id.au>
Tue, 27 Feb 2024 12:57:43 +0000 (23:57 +1100)
committerJoel Sing <joel@sing.id.au>
Fri, 1 Mar 2024 08:06:08 +0000 (08:06 +0000)
commitb5a64ba62eafe5dee13562091ca03aef6cac87b6
tree386e8e730b0b5f9293582cbabde20774ec68ea29
parentcda1e40b44771f8a01f361672cba721d0f283683
cmd/link/internal/riscv64: generate local text symbols for R_RISCV_CALL

Correctly generate local text symbols needed for R_RISCV_CALL when
external linking. R_RISCV_CALL was added in CL #520095 as a way of
marking AUIPC+JALR pairs, instead of overloading R_RISCV_PCREL_ITYPE.
However, genSymsLate was not updated to generate local text symbols
for the new relocation type, leading to HI20 symbol lookup failures.

This issue is detected by cmd/internal/obj/riscv.TestLargeCall,
however this is unfortunately skipped in short mode.

Fixes #65646

Change-Id: I8ee0f13791e0628f31657bf7dae2be8482b689b5
Reviewed-on: https://go-review.googlesource.com/c/go/+/567375
Reviewed-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Run-TryBot: Joel Sing <joel@sing.id.au>
Reviewed-by: Cherry Mui <cherryyz@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
src/cmd/link/internal/riscv64/asm.go