]> Cypherpunks repositories - gostls13.git/commit
cmd/go: clean up x.exe properly in TestImportMain
authorRuss Cox <rsc@golang.org>
Tue, 17 Oct 2017 19:10:59 +0000 (15:10 -0400)
committerRuss Cox <rsc@golang.org>
Wed, 18 Oct 2017 00:21:04 +0000 (00:21 +0000)
commitb614ed4ca4531011b3913d904cb37a855f38bf8a
tree812df26348b23f141375dbbbc1264cc4cd3d6dd1
parentddc64def0f3e8cfdd5e6705e5f1c454a8d5e24d4
cmd/go: clean up x.exe properly in TestImportMain

More generally I'm concerned about these tests using
$GOROOT/src/cmd/go as scratch space, especially
combined wtih tg.parallel() - it's easy to believe some other
test might inadvertently also try to write x.exe about the
same time. This CL only solves the "didn't clean up x.exe"
problem and leaves for another day the "probably shouldn't
write to cmd/go at all" problem.

Fixes #22266.

Change-Id: I651534d70e2d360138e0373fb4a316081872550b
Reviewed-on: https://go-review.googlesource.com/71410
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
src/cmd/go/go_test.go