]> Cypherpunks repositories - gostls13.git/commit
go/types, types: better error message position for invalid receiver errors
authorRobert Griesemer <gri@golang.org>
Wed, 20 Nov 2024 21:57:23 +0000 (13:57 -0800)
committerGopher Robot <gobot@golang.org>
Thu, 21 Nov 2024 05:01:47 +0000 (05:01 +0000)
commitb631b8e674195f6cdeca363ccb01279f14b10f13
tree1cbc0e41c68cf659a2dad57576f6e9d80f7abc10
parenta9428eab40f799c96c0de7385545c03d989d491a
go/types, types: better error message position for invalid receiver errors

Errors related to invalid receivers are based on the receiver base type.
Position the error message at the receiver base type, not the receiver
variable.

Add an additional example with an (invalid) generic receiver type.

Also, fix a panic when the code is run w/o Alias types enabled.

Change-Id: I610df171e4c447bbe03b904937c12e4170508b3b
Reviewed-on: https://go-review.googlesource.com/c/go/+/630376
Reviewed-by: Tim King <taking@google.com>
Auto-Submit: Robert Griesemer <gri@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
Reviewed-by: Robert Griesemer <gri@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
src/cmd/compile/internal/types2/issues_test.go
src/cmd/compile/internal/types2/signature.go
src/cmd/compile/internal/types2/typexpr.go
src/go/types/issues_test.go
src/go/types/signature.go
src/go/types/typexpr.go
src/internal/types/testdata/check/decls2/decls2a.go
src/internal/types/testdata/spec/receivers.go [new file with mode: 0644]