]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: remove incorrect arm,arm64 CMP->CMN transformations
authorDavid Chase <drchase@google.com>
Thu, 27 Jan 2022 16:26:59 +0000 (11:26 -0500)
committerDavid Chase <drchase@google.com>
Thu, 27 Jan 2022 19:52:52 +0000 (19:52 +0000)
commitb7b44b3173f151a2313da7072afd25de80511605
tree86d7aa73532175991078484ec92f0f3da3607386
parentb2dc66c64db933120c34d2223e670e8594543bd9
cmd/compile: remove incorrect arm,arm64 CMP->CMN transformations

These can go wrong when one of the operands is the minimum integer value.

Fixes #50854.

Change-Id: I238fe284f60c7ee5aeb9dc9a18e8b1578cdb77d0
Reviewed-on: https://go-review.googlesource.com/c/go/+/381318
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Trust: David Chase <drchase@google.com>
Run-TryBot: David Chase <drchase@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
src/cmd/compile/internal/ssa/gen/ARM.rules
src/cmd/compile/internal/ssa/gen/ARM64.rules
src/cmd/compile/internal/ssa/gen/ARM64Ops.go
src/cmd/compile/internal/ssa/gen/ARMOps.go
src/cmd/compile/internal/ssa/rewriteARM.go
src/cmd/compile/internal/ssa/rewriteARM64.go
test/fixedbugs/issue50854.go [new file with mode: 0644]