]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: fix early deadcode with label statement
authorCuong Manh Le <cuong.manhle.vn@gmail.com>
Wed, 21 Feb 2024 11:50:11 +0000 (18:50 +0700)
committerGopher Robot <gobot@golang.org>
Tue, 27 Feb 2024 21:07:10 +0000 (21:07 +0000)
commitb847d4cd2c2293d025720d4ae57b2e9578831d29
treeb29f2c8dd0493884252b81ca535940fb8b083101
parentfdb200834feb8bd8e5d0073d83c51f68e364d0fd
cmd/compile: fix early deadcode with label statement

CL 517775 moved early deadcode into unified writer. with new way to
handle dead code with label statement involved: any statements after
terminating statement will be considered dead until next label
statement.

However, this is not safe, because code after label statement may still
refer to dead statements between terminating and label statement.

It's only safe to remove statements after terminating *and* label one.

Fixes #65593

Change-Id: Idb630165240931fad50789304a9e4535f51f56e2
Reviewed-on: https://go-review.googlesource.com/c/go/+/565596
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Keith Randall <khr@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Auto-Submit: Cuong Manh Le <cuong.manhle.vn@gmail.com>
src/cmd/compile/internal/noder/writer.go
test/fixedbugs/issue65593.go [new file with mode: 0644]