]> Cypherpunks repositories - gostls13.git/commit
net/http/httptest: don't register a flag unless it looks like it's in use
authorBrad Fitzpatrick <bradfitz@golang.org>
Fri, 14 Dec 2018 18:33:13 +0000 (18:33 +0000)
committerBrad Fitzpatrick <bradfitz@golang.org>
Fri, 14 Dec 2018 19:56:15 +0000 (19:56 +0000)
commitb875991a49ac6d323c9c52c889429eb3b1642ef7
treedac8a458935e54e573166211dad6f439765bd181
parentdbd323bb880ff27fa9b4bdfebf3e5d4828b09678
net/http/httptest: don't register a flag unless it looks like it's in use

We shouldn't pollute people's flags with this debugging flag that was
never really meant to be public. It's certainly not documented.

So keep it for now, but don't register it unless it looks like it's in
use (by looking at os.Args). Kinda gross, but less gross than before.

Fixes #28619

Change-Id: I47498948a26a71ff36f9658a6d9dac73fd0a3016
Reviewed-on: https://go-review.googlesource.com/c/154217
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Andrew Bonventre <andybons@golang.org>
src/net/http/httptest/server.go