]> Cypherpunks repositories - gostls13.git/commit
cmd/internal/obj/arm: fix illegal forms of ARM VFP instruction
authorBen Shi <powerman1st@163.com>
Tue, 23 May 2017 11:15:41 +0000 (11:15 +0000)
committerCherry Zhang <cherryyz@google.com>
Thu, 25 May 2017 14:32:35 +0000 (14:32 +0000)
commitb8a4eb4bd8820ca50fee3aff4b8d5adb7a0a9b49
tree1b6ffa051074c90456b8f093c85df092b2be7476
parent13ae3b3a8d345b71a5f424f9b61fa39393efccca
cmd/internal/obj/arm: fix illegal forms of ARM VFP instruction

"ADDF F0, R1, F2" is silently accepted by the arm assembler and
assembled to the same binary code of "ADDF F0, F1, F2". So does
"CMPF F0, R1".

"ABSF F0, F1, F2" is also silently accepted and assembled to a
different instruction.

This patch reports those illegal forms and adds test cases.

fix #20464

Change-Id: I88b80dc29de24c6266ac7bf7bce1578c5adbc68c
Reviewed-on: https://go-review.googlesource.com/43931
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
src/cmd/asm/internal/asm/endtoend_test.go
src/cmd/asm/internal/asm/testdata/armerror.s
src/cmd/internal/obj/arm/asm5.go