]> Cypherpunks repositories - gostls13.git/commit
cmd/go: version command should error when given bad args
authorDaniel Martí <mvdan@mvdan.cc>
Thu, 27 Feb 2020 16:19:06 +0000 (16:19 +0000)
committerDaniel Martí <mvdan@mvdan.cc>
Fri, 28 Feb 2020 09:29:22 +0000 (09:29 +0000)
commitb8f54e57c20368db5693b941fd6f79634b067cb0
treecb989be05b576b5800573cd55c8e66bd9e51f3b1
parent18053b7131fff206b11c73bd1db3b024f4d0589e
cmd/go: version command should error when given bad args

For example, 'go version -m' happily gives you Go's own version, even
though the -m flag only makes sense when grabbing the version of a
binary on disk.

Similarly, if any of the directly named files can't be found, the tool
would succeed. That's acceptable if an error is encountered while
walking a large directory, but not when locating a path directly given
by the user.

These added test cases run even in short mode, as 'go build' is not
needed for them.

Change-Id: I7bb40b72853799e31d9f86cc5e999c8d57813eef
Reviewed-on: https://go-review.googlesource.com/c/go/+/221397
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
src/cmd/go/internal/version/version.go
src/cmd/go/testdata/script/version.txt