]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: retain source positions of arguments to inlined calls
authorDavid Lazar <lazard@golang.org>
Sat, 27 May 2017 21:43:37 +0000 (17:43 -0400)
committerDavid Lazar <lazard@golang.org>
Fri, 2 Jun 2017 13:41:01 +0000 (13:41 +0000)
commitb928e2faa8d90989276ff0880aaef666c970cc68
tree127cfd9fc9baba00e9b3f6f5f0d06f3c897012d4
parent6db87c4faaafebb6cecbb3c02bff67aafdc5d971
cmd/compile: retain source positions of arguments to inlined calls

Arguments to inlined calls are hidden from setPos as follows:

    args := as.Rlist
    as.Rlist.Set(nil)
    // setPos...
    as.Rlist.Set(args.Slice())

Previously, this code had no effect since the value of as was
overwritten by the assignment in the retvars loop.

Fixes #19799.

Change-Id: Iaf97259f82fdba8b236136337cc42b2774c7fef5
Reviewed-on: https://go-review.googlesource.com/44351
Run-TryBot: David Lazar <lazard@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
src/cmd/compile/internal/gc/inl.go
test/fixedbugs/issue19799.go [new file with mode: 0644]