]> Cypherpunks repositories - gostls13.git/commit
runtime: unwind BP in jmpdefer to match SP unwind
authorAustin Clements <austin@google.com>
Thu, 26 May 2016 00:56:56 +0000 (20:56 -0400)
committerAustin Clements <austin@google.com>
Thu, 26 May 2016 13:54:05 +0000 (13:54 +0000)
commitb92f4238790c590168e7dae03165d75deb89fe41
tree54d3adc497c61e4857f37f6411ea65070fd012b9
parentadff422779709c83db91700fdcc0a0bd5dee6a21
runtime: unwind BP in jmpdefer to match SP unwind

The irregular calling convention for defers currently incorrectly
manages the BP if frame pointers are enabled. Specifically, jmpdefer
manipulates the SP as if its own caller, deferreturn, had returned.
However, it does not manipulate the BP to match. As a result, when a
BP-based traceback happens during a deferred function call, it unwinds
to the function that performed the defer and then thinks that function
called itself in an infinite regress.

Fix this by making jmpdefer manipulate the BP as if deferreturn had
actually returned.

Fixes #12968.

Updates #15840.

Change-Id: Ic9cc7c863baeaf977883ed0c25a7e80e592cf066
Reviewed-on: https://go-review.googlesource.com/23457
Reviewed-by: Russ Cox <rsc@golang.org>
Run-TryBot: Austin Clements <austin@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
src/runtime/asm_amd64.s