]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: better integrate parameter tagging with escape.go
authorMatthew Dempsky <mdempsky@google.com>
Wed, 4 Sep 2019 22:16:25 +0000 (15:16 -0700)
committerMatthew Dempsky <mdempsky@google.com>
Tue, 10 Sep 2019 23:01:30 +0000 (23:01 +0000)
commitb9704872d11ae224ca96a1bd2fab0da10ce806d7
treeafc06d5970df320f91082b47c1c30fbd1c19dc8c
parent68a653684823b6d63286bef785ab3a2df09ec552
cmd/compile: better integrate parameter tagging with escape.go

This CL moves parameter tagging to before escape analysis is complete,
so we still have access to EscLocation. This will be useful once
EscLocation starts tracking higher-fidelity escape details.

Notably, this CL stops using n.Esc to record parameter escape analysis
details. Now escape analysis only ever sets n.Esc to EscNone or
EscHeap. (It still defaults to EscUnknown, and is set to EscNever in
some places though.)

Passes toolstash-check.

Updates #33981.

Change-Id: I50a91ea1e38c442092de6cd14e20b211f8f818c9
Reviewed-on: https://go-review.googlesource.com/c/go/+/193178
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
src/cmd/compile/internal/gc/esc.go
src/cmd/compile/internal/gc/escape.go
test/uintptrescapes2.go