]> Cypherpunks repositories - gostls13.git/commit
net/http: add NoBody, don't return nil from NewRequest on zero bodies
authorBrad Fitzpatrick <bradfitz@golang.org>
Sat, 22 Oct 2016 16:47:05 +0000 (09:47 -0700)
committerBrad Fitzpatrick <bradfitz@golang.org>
Sat, 22 Oct 2016 19:44:53 +0000 (19:44 +0000)
commitb992c391d4aae64e147fc64c77ad41d61be8e2e7
treed29aba00374f9496d639f9b5e259aca14d9d734e
parent448e1db103df7a9b29aa360f42fdcdc9b89fa399
net/http: add NoBody, don't return nil from NewRequest on zero bodies

This is an alternate solution to https://golang.org/cl/31445

Instead of making NewRequest return a request with Request.Body == nil
to signal a zero byte body, add a well-known variable that means
explicitly zero.

Too many tests inside Google (and presumably the outside world)
broke.

Change-Id: I78f6ecca8e8aa1e12179c234ccfb6bcf0ee29ba8
Reviewed-on: https://go-review.googlesource.com/31726
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Joe Tsai <thebrokentoaster@gmail.com>
src/net/http/http.go
src/net/http/readrequest_test.go
src/net/http/request.go
src/net/http/request_test.go
src/net/http/response.go
src/net/http/server.go
src/net/http/transfer.go