]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: fix buglet in walk convert phase relating to convF32/64
authorThan McIntosh <thanm@google.com>
Thu, 8 Apr 2021 19:30:03 +0000 (15:30 -0400)
committerThan McIntosh <thanm@google.com>
Thu, 8 Apr 2021 19:58:50 +0000 (19:58 +0000)
commitbb76193a7f0b04c6c25696ed28dd5516ae23d83c
treebcd9ddca769a8d25ee384d3053f9a03bb71ded9d
parent793844207d81bdc41212bc300195469c65c39766
cmd/compile: fix buglet in walk convert phase relating to convF32/64

The helper function used by the compiler's walk phase to determine
whether a param can be passed in a single float register wasn't quite
correct (didn't allow for the possibility of struct with two fields,
first zero size and second float). Fix up the helper to take this
case into account.

Updates #40724.

Change-Id: I55b42a1b17ea86de1d696788f029ad3aae4a179c
Reviewed-on: https://go-review.googlesource.com/c/go/+/308689
Trust: Than McIntosh <thanm@google.com>
Run-TryBot: Than McIntosh <thanm@google.com>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
src/cmd/compile/internal/walk/convert.go
test/abi/convF_criteria.go [new file with mode: 0644]
test/abi/convF_criteria.out [new file with mode: 0644]