]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: skip generating args_stackmap for "pulled" funcs
authorMatthew Dempsky <mdempsky@google.com>
Thu, 12 Mar 2020 19:14:02 +0000 (12:14 -0700)
committerMatthew Dempsky <mdempsky@google.com>
Mon, 23 Mar 2020 03:56:18 +0000 (03:56 +0000)
commitbb929b7452b5b8a6a584a94a110c98b0c6543a6e
tree1b1df30c16ef93aa8f6127df3cfe978afe7d68f7
parent0c302459968511865ec6a5ee4ff2172e4e54cef8
cmd/compile: skip generating args_stackmap for "pulled" funcs

In golang.org/cl/171464, we cleaned up generation of .stkobj linker
symbols, but we couldn't figure out why a similar cleanup to
.args_stackmap linker symbols caused problems.

The issue is that we only need/want to generate .args_stackmap for
functions that are implemented in assembly in the same package. When
"pulling" a function from another package via //go:linkname, we can
safely skip emitting .args_stackmap, because compiling that package
will have generated it, if necessary.

Fixes #31615.

Change-Id: If8680aa7dd5b4e8f268b6b032d746f1b8536c867
Reviewed-on: https://go-review.googlesource.com/c/go/+/223238
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Keith Randall <khr@golang.org>
src/cmd/compile/internal/gc/pgen.go