]> Cypherpunks repositories - gostls13.git/commit
runtime: rename getcallerfp to getfp
authorFelix Geisendörfer <felix.geisendoerfer@datadoghq.com>
Mon, 3 Apr 2023 23:10:55 +0000 (01:10 +0200)
committerMichael Pratt <mpratt@google.com>
Thu, 11 May 2023 15:18:52 +0000 (15:18 +0000)
commitbc9e21351c2b9f0802304198860afbd4f1381e75
treec4c64c38da2b97526c70c01db2e9d9968850c574
parentdc076eaf2e64f51cca986a4a340a51befd7b6250
runtime: rename getcallerfp to getfp

The previous name was wrong due to the mistaken assumption that calling
f->g->getcallerpc and f->g->getcallersp would respectively return the
pc/sp at g. However, they are actually referring to their caller's
caller, i.e. f.

Rename getcallerfp to getfp in order to stay consistent with this
naming convention.

Also see discussion on CL 463835.

For #16638

Change-Id: I07990645da78819efd3db92f643326652ee516f8
Reviewed-on: https://go-review.googlesource.com/c/go/+/481617
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Run-TryBot: Felix Geisendörfer <felix.geisendoerfer@datadoghq.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
15 files changed:
src/runtime/asm_amd64.s
src/runtime/asm_arm64.s
src/runtime/export_test.go
src/runtime/os_wasm.go
src/runtime/stubs_386.go
src/runtime/stubs_amd64.go
src/runtime/stubs_arm.go
src/runtime/stubs_arm64.go
src/runtime/stubs_loong64.go
src/runtime/stubs_mips64x.go
src/runtime/stubs_mipsx.go
src/runtime/stubs_ppc64x.go
src/runtime/stubs_riscv64.go
src/runtime/stubs_s390x.go
src/runtime/trace.go