]> Cypherpunks repositories - gostls13.git/commit
crypto/tls: parse certificate first in X509KeyPair to get better errors
authorFilippo Valsorda <hi@filippo.io>
Sun, 28 Jan 2018 22:30:48 +0000 (23:30 +0100)
committerFilippo Valsorda <filippo@golang.org>
Tue, 27 Mar 2018 21:47:54 +0000 (21:47 +0000)
commitbd18c09095ed432f9638b3b1181b3c5390c8c51c
tree734193d194145c200329690e427eda7c5d88cb17
parenta25d0d8fb901e9b6fa68b0f9d4e23d16bf201aff
crypto/tls: parse certificate first in X509KeyPair to get better errors

parsePrivateKey can't return useful error messages because it does trial
decoding of multiple formats.  Try ParseCertificate first in case it
offers a useful error message.

Fixes #23591

Change-Id: I380490a5850bee593a7d2f584a27b2a14153d768
Reviewed-on: https://go-review.googlesource.com/90435
Run-TryBot: Filippo Valsorda <filippo@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Adam Langley <agl@golang.org>
src/crypto/tls/tls.go