]> Cypherpunks repositories - gostls13.git/commit
internal/testenv: add a test for the GoTool function
authorBryan C. Mills <bcmills@google.com>
Fri, 28 Jan 2022 20:54:49 +0000 (15:54 -0500)
committerGopher Robot <gobot@golang.org>
Wed, 17 Aug 2022 16:08:04 +0000 (16:08 +0000)
commitbd1bff4e7aa1e417aaa617a7f10b1cff88a6e243
treedd2f1438567a63fd0dc6730d8dd05d634636b407
parentd09c6ac41769cc782ec982ffc8f20fbd796791f8
internal/testenv: add a test for the GoTool function

GoTool was added in CL 20967, and revised in CL 21292, for #14901.

I don't fully understand what problem the GoTool function was added to
solve: the discussion on that issue was pretty sparse, but it seems
like when we run tests of GOROOT packages they always know their own
location relative to GOROOT (and thus always know where to find the
'go' tool).

Lacking that understanding, I don't want to change its behavior, but I
do at least want to verify that it resolves to the real 'go' tool in
the common case (running 'go test' on a package in GOROOT/src).

For #50892
For #50893
Updates #14901

Change-Id: I06d831e6765be631dfc4854d7fddc3d27fc1de34
Reviewed-on: https://go-review.googlesource.com/c/go/+/381834
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: David Chase <drchase@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
src/internal/testenv/testenv_test.go [new file with mode: 0644]