]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: fix GOEXPERIMENT checks
authorMatthew Dempsky <mdempsky@google.com>
Wed, 29 Nov 2017 20:26:59 +0000 (12:26 -0800)
committerMatthew Dempsky <mdempsky@google.com>
Fri, 1 Dec 2017 00:40:45 +0000 (00:40 +0000)
commitbd983a6d2e8b6b0385724ef05872ba659111ec20
treedc5fe7f055a59a74254fafc81dfed66b173ba1bf
parentf3b24b9f0766351fc8b3d43c4ea03f948a460e75
cmd/compile: fix GOEXPERIMENT checks

GOEXPERIMENT is only set during make.bash, so checking the environment
variable isn't effectual. Instead, check the values exposed by objabi.

These experiments look potentially safe, but it seems too late in the
release cycle to try to assuage that. The one exception is frame
pointer experiment, which is trivially safe: it just amounts to
incrementing some stack offsets by PtrSize.

Fixes #22223.

Change-Id: I46dc7c54b1347143d02d6b9635038230cda6d164
Reviewed-on: https://go-review.googlesource.com/80760
Reviewed-by: Russ Cox <rsc@golang.org>
src/cmd/compile/internal/gc/main.go
src/cmd/go/internal/work/exec.go
src/cmd/go/internal/work/gc.go