]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: minor simplifications in rulegen
authorDaniel Martí <mvdan@mvdan.cc>
Mon, 23 Sep 2019 22:10:25 +0000 (23:10 +0100)
committerDaniel Martí <mvdan@mvdan.cc>
Fri, 27 Sep 2019 18:58:08 +0000 (18:58 +0000)
commitbdf0fe54480034cd21e36cfed6e44f10f4cb5c92
treefdb4fd84b8ad3b23bbbc253a1dbb2f2205bf8bb2
parent95b8cbfee93766274583bacfb98b3b0cc1dbb6cf
cmd/compile: minor simplifications in rulegen

First, be consistent about declaring typ as &b.Func.Config.Types and
not &config.Types. Not particularly better, and it barely changes the
output, but we're more consistent now.

Second, remove a bit of duplication when handling the typ, auxint, and
aux variables.

Third and last, remove a stray canFail assignment; we ended up setting
that in add, not breakf, so it's not necessary to set it manually if we
don't use breakf.

Updates #33644.

Change-Id: I75999cb223a201969266fbfeae043599fa27fac5
Reviewed-on: https://go-review.googlesource.com/c/go/+/196803
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
Reviewed-by: Keith Randall <khr@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
src/cmd/compile/internal/ssa/gen/rulegen.go
src/cmd/compile/internal/ssa/rewriteS390X.go